astropy-tutorials icon indicating copy to clipboard operation
astropy-tutorials copied to clipboard

ExtractOutputPreprocessor isn't being used by nbcollection?

Open jonathansick opened this issue 2 years ago • 2 comments

In #530 we enabled the ExtractOutputPreprocessor (which extracts figures from html files, thereby making them something that the UI can source in the cards). However, this doesn't seem to actually be running. If you look at any rendered-tutorials artifact, the figures are definitely still embedded.

Are traits not getting passed by nbcollection to nbconvert? Any ideas @adrn?

Now, we can work around this by having Learn Astropy Librarian extract the figures and put them on some static file host (while doing some sort of resizing and optimization... which we may need to do regardless), however, it'd be good to understand what's going on here.

jonathansick avatar Apr 01 '22 17:04 jonathansick

Hm, not sure! I can look into this next week

adrn avatar Apr 07 '22 14:04 adrn

I think this commit will fix the issue: https://github.com/astropy/nbcollection/commit/a1101efbf140d872a8220a6bbb3d95f29a9887f0

adrn avatar Apr 14 '22 15:04 adrn