astropy-tutorials icon indicating copy to clipboard operation
astropy-tutorials copied to clipboard

New tutorials: Using synphot for synthetic photometry

Open tcjansen opened this issue 5 years ago • 8 comments

Hi all, I'm a GSoC student working with @bmorris3, @pllim, and @eteq. During the early stages of my project I developed some example use cases for synphot that I think could also be helpful for the astronomical community. In this tutorial we show how to use synphot to predict photometric fluxes of an SDSS observation, and I plan on submitting another tutorial for creating synthetic photometry using model spectra.

This is my first PR to astropy-tutorials, so suggestions are very welcome!

Fixes #424

tcjansen avatar Aug 08 '19 21:08 tcjansen

Pinging @tcjansen once more about this PR 😄

bmorris3 avatar Nov 01 '19 12:11 bmorris3

Hi @tcjansen Would you like me to push changes to your branch to resolve the issues/conflicts needed to be addressed, or would you like to make these changes yourself? I understand @bmorris3 really would like to see this work gets merged and published to Learn Astropy soon. Anyway, please let me know.

kakirastern avatar Aug 25 '20 13:08 kakirastern

Absolutely! I would also really like to get this merged. Thanks for bringing it back to my attention, I will start working on it this week.

tcjansen avatar Aug 26 '20 00:08 tcjansen

Sure @tcjansen Do let me know if I could be of any help. Also, remember to rebase against the origin/master before you resume work on the PR again.

kakirastern avatar Aug 26 '20 14:08 kakirastern

👋 We have changed the build infrastructure and layout of files in the repo, so I am going to rebase this pull request and force push to your branch. If you have any local changes that haven't been pushed, please push them by the end of this week (October 1). After I have rebased to bring the new build machinery in, please let us know if you would like to continue working on this tutorial or if you would rather someone else take it over. Thanks!

adrn avatar Sep 28 '21 15:09 adrn

@adrn Hi, thanks for the update/nudge! Looks like this fell off my radar because I just could not understand why the ci/circleci check is failing :sweat_smile:... If anyone has any suggestions I would be happy to take another look, otherwise I wouldn't mind if someone else wanted to take it over.

tcjansen avatar Sep 30 '21 20:09 tcjansen

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Cool! I just rebased to pull in the latest changes to the infrastructure (hopefully that will fix the failing build!), so you'll need to git pull to get those changes locally.

adrn avatar Oct 04 '21 13:10 adrn