astropy-project icon indicating copy to clipboard operation
astropy-project copied to clipboard

Proposal to add @svank as a reproject maintainer

Open astrofrog opened this issue 1 year ago • 15 comments

Following the process described here I would like to propose adding Sam Van Kooten (@svank) as a reproject maintainer. Sam has contributed a significant sub-module (reproject.adaptive) as well as other significant improvements and has the skills and understanding of the code and process to become a maintainer for the coordinated package.

Is it correct that the CoCo will handle the process from this point onwards as described in the policy? Let me know if there is anything I can do to help.

@svank - could you confirm that you would still be happy to be a co-maintainer? (I think Stuart or I chatted with you about this a while back)

astrofrog avatar Jul 19 '24 10:07 astrofrog

reproject isn't in core library, but a coordinated package. Not sure if the policy strictly applies to this package. I think you could have just opened a PR straight if you wanted. For example, when William left STScI and someone else took over, we switched asdf-astropy (also coordinated package) maintainers without much hurrah.

pllim avatar Jul 19 '24 13:07 pllim

Maintainers of coordinated packages have roles on the team page, and as such I believe they follow the same process as core. The idea of having them be coordinated packages is precisely that their management is overseen by the project.

astrofrog avatar Jul 19 '24 13:07 astrofrog

The policy at https://github.com/astropy/astropy-project/blob/main/policies/adding-new-role-members.md does not specifically mention the core package, it is a policy for all roles.

astrofrog avatar Jul 19 '24 13:07 astrofrog

Okay then. CoCo will meet on 2024-07-22.

pllim avatar Jul 19 '24 13:07 pllim

I believe they follow the same process as core

If only we could speak for maintenance as well... But that is a battle for another day.

pllim avatar Jul 19 '24 13:07 pllim

An additional point to raise with the CoCo is whether the policy could be relaxed so that it is not the CoCo that is responsible for the whole process of filling roles - that is, perhaps any existing role holder could propose someone to hold a role and start the whole 2 week process etc.

astrofrog avatar Jul 19 '24 13:07 astrofrog

Re: https://github.com/astropy/astropy-project/issues/435#issuecomment-2239194529

Might go faster if you open a PR with proposed change and CoCo can discuss on Monday.

pllim avatar Jul 19 '24 13:07 pllim

@pllim - done in https://github.com/astropy/astropy.github.com/pull/611

astrofrog avatar Jul 19 '24 13:07 astrofrog

Oh, I mean proposal to update the policy. 😅

pllim avatar Jul 19 '24 13:07 pllim

Oh I see, will do

astrofrog avatar Jul 19 '24 13:07 astrofrog

Hmm actually I'm not really sure about changing it, I'll leave it to the CoCo to think about how they would like to handle this.

astrofrog avatar Jul 19 '24 13:07 astrofrog

I'm not really sure about changing it

What do you mean? Does your request at https://github.com/astropy/astropy-project/issues/435#issuecomment-2239194529 still stand or you have a different request now?

pllim avatar Jul 19 '24 16:07 pllim

@svank - could you confirm that you would still be happy to be a co-maintainer? (I think Stuart or I chatted with you about this a while back)

Yes, I'm still happy to do it (though as I've never been a maintainer before, we should probably have an orientation chat at some point)

svank avatar Jul 19 '24 19:07 svank

Whatever you chat about, please take high-level notes, @astrofrog and/or @svank , because I think we need a real maintainer onboarding guide!

pllim avatar Jul 19 '24 20:07 pllim

Re: onboarding -- Coincidentally, I dug up this old issue that's still open. 😬 https://github.com/astropy/astropy-project/issues/158

pllim avatar Jul 29 '24 18:07 pllim

Congrats and welcome to the team!

pllim avatar Aug 06 '24 13:08 pllim