astroplan icon indicating copy to clipboard operation
astroplan copied to clipboard

Added in moon option for plot_airmass

Open cagostino opened this issue 6 years ago • 4 comments

I think this would be a useful feature to have in plot_airmass as it's easily calculable just with the information given and I think this would be a common enough calculation people have to do that it would be worth having to save a little bit of time.

cagostino avatar Mar 26 '18 05:03 cagostino

@cagostino any way you can clean this up and get submitted? If you don't have time let me know. I'm at a hack-week this week and might try to clean up some of the airmass plots so would just incorporate this. Same with #354

wtgee avatar Feb 10 '20 20:02 wtgee

@wtgee yeah probably. I was not exactly sure what to do with #354 since its checks were no longer working and weren't showing any details as to why. Would be happy to get that one through though.

cagostino avatar Feb 10 '20 20:02 cagostino

I fixed what you had suggested previously, let me know if there is anything else I can do to move this along @wtgee

cagostino avatar Feb 10 '20 21:02 cagostino

I fixed what you had suggested previously, let me know if there is anything else I can do to move this along @wtgee

Thanks! There's a conflict in one of the files still, if you could clean that up @bmorris3 can then take a look for merging.

wtgee avatar Feb 10 '20 23:02 wtgee