astronomer-providers icon indicating copy to clipboard operation
astronomer-providers copied to clipboard

Amazon test cleanup

Open pankajastro opened this issue 2 years ago • 3 comments

closes: https://github.com/astronomer/astronomer-providers/issues/690 related-to: https://github.com/astronomer/astronomer-providers/issues/568

  • convert the function-based test to a class-based
  • remove context fixture definition from operator/sensor/extractor and reuse from conftest
  • consolidate EMR sensor tests into a single test file
  • remove function create_context from a couple of test files and reuse it from the util

pankajastro avatar Oct 01 '22 16:10 pankajastro

tests/amazon/aws/sensors/test_emr.py why is this file deleted? and where is the corresponding test cases for it?

rajaths010494 avatar Oct 06 '22 12:10 rajaths010494

tests/amazon/aws/sensors/test_emr.py why is this file deleted? and where is the corresponding test cases for it?

Moved it test_emr_sensors.py i.e merged tests/amazon/aws/sensors/test_emr.py and tests/amazon/aws/sensors/test_emr_sensors.py

pankajastro avatar Oct 06 '22 12:10 pankajastro

@pankajastro can we take up this?

bharanidharan14 avatar Oct 14 '22 06:10 bharanidharan14

Codecov Report

Base: 98.54% // Head: 98.54% // No change to project coverage :thumbsup:

Coverage data is based on head (1dbbaa9) compared to base (14fec33). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          88       88           
  Lines        4882     4882           
=======================================
  Hits         4811     4811           
  Misses         71       71           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 10 '23 10:01 codecov[bot]

Rebase the branch.

rajaths010494 avatar Jan 10 '23 14:01 rajaths010494

Thanks @pankajastro for changing the amazon related test cases to class based it was a huge one.

rajaths010494 avatar Jan 10 '23 15:01 rajaths010494