astronomer-providers icon indicating copy to clipboard operation
astronomer-providers copied to clipboard

`make docs` dev command failed on main branch

Open pankajastro opened this issue 2 years ago • 3 comments

Describe the bug Recently I'm facing an issue while running make docs in my env. may be related to https://github.com/executablebooks/sphinx-copybutton/issues/170 issue but not sure

To Reproduce run make docs in astronomer-providers

Screenshot 2022-09-24 at 12 38 31 AM

pankajastro avatar Sep 23 '22 19:09 pankajastro

Did you build the image from scratch?

The following library should be installed https://github.com/astronomer/astronomer-providers/blob/3b41eb70b14104b1a57a85c413edb708fa7d2359/setup.cfg#L81

kaxil avatar Sep 23 '22 21:09 kaxil

Did you build the image from scratch?

The following library should be installed

https://github.com/astronomer/astronomer-providers/blob/3b41eb70b14104b1a57a85c413edb708fa7d2359/setup.cfg#L81

hmm, After your comments, I build it from scratch with

make stop
make clean
docker system prune -a
make build-run

but the issue persists. I was trying this from pychram terminal in conda env but after manually installing sphinx-copybutton in env with conda install -c conda-forge sphinx-copybutton it started working

pankajastro avatar Sep 24 '22 16:09 pankajastro

Looks like it is because the make docs command does not currently use docker.. maybe run pip install -e .[docs] in that?

https://github.com/astronomer/astronomer-providers/blob/3b41eb70b14104b1a57a85c413edb708fa7d2359/Makefile#L45-L46

kaxil avatar Sep 26 '22 11:09 kaxil

running

pip install -e .[docs]

and then make docs worked!

pankajastro avatar Jan 10 '23 15:01 pankajastro