astronomer-providers icon indicating copy to clipboard operation
astronomer-providers copied to clipboard

Add new Great Expectations Provider

Open denimalpaca opened this issue 2 years ago • 3 comments

New operator is added with limited testing, as it is a first draft that may not be using certain elements of the GE project in an efficient or correct manner. It is prudent to have the operator cleaned up first before high-coverage testing is added to functions that may change significantly or be removed. Additionally, no example DAG is yet prepared as parameters to the operator may change significantly.

denimalpaca avatar Jul 06 '22 13:07 denimalpaca

Congrats @denimalpaca on your first PR ! Just a quick question, this does not seem to be an async operator. So why are we looking to merge this into astronomer providers.

Hey @phanikumv, @virajmparekh and I spoke with members of the Airflow team and Great Expectations team that this would be the correct repository for an Astronomer-hosted, Superconductive-assisted new version of the operator. If this repository is only for Async operators I'll close this request and open in a different repo, but my understanding is that we will be putting all Astronomer-supported providers and operators here and merge them back into Airlfow OSS at a later date.

denimalpaca avatar Jul 06 '22 15:07 denimalpaca

Congrats @denimalpaca on your first PR ! Just a quick question, this does not seem to be an async operator. So why are we looking to merge this into astronomer providers.

Hey @phanikumv, @virajmparekh and I spoke with members of the Airflow team and Great Expectations team that this would be the correct repository for an Astronomer-hosted, Superconductive-assisted new version of the operator. If this repository is only for Async operators I'll close this request and open in a different repo, but my understanding is that we will be putting all Astronomer-supported providers and operators here and merge them back into Airlfow OSS at a later date.

Let's hold off on this PR for now until we discuss it. I am not aware of and not part of that discussion where we concluded that it should be part of this repo.

kaxil avatar Jul 07 '22 13:07 kaxil

Codecov Report

Merging #503 (7cce637) into main (0948767) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          72       72           
  Lines        3996     3996           
=======================================
  Hits         3927     3927           
  Misses         69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0948767...7cce637. Read the comment docs.

codecov[bot] avatar Aug 01 '22 18:08 codecov[bot]

Permanently moved to the Great Expectations provider repo.

denimalpaca avatar Oct 13 '22 16:10 denimalpaca