astronomer-cosmos icon indicating copy to clipboard operation
astronomer-cosmos copied to clipboard

Enhance manifest structure validation and add debug logging

Open AlgirdasDubickas opened this issue 11 months ago • 2 comments

This commit introduces several improvements to the manifest file processing logic to ensure robustness and ease of debugging:

  1. Manifest Structure Validation: Added checks to verify that the manifest file contains the expected top-level keys ("nodes", "sources", "exposures").

  2. Data Type Validation: Implemented additional validation to confirm that the "nodes" key maps to a dictionary. This step helps catch issues where the manifest's format deviates from expected structures, particularly in how nodes are represented.

  3. Key Presence Validation: For each node within the manifest, we now verify the presence of essential keys ("resource_type", "original_file_path", "tags", "config").

Description

Related Issue(s)

Breaking Change?

Checklist

  • [ ] I have made corresponding changes to the documentation (if required)
  • [ ] I have added tests that prove my fix is effective or that my feature works

AlgirdasDubickas avatar Mar 09 '24 07:03 AlgirdasDubickas

Deploy Preview for sunny-pastelito-5ecb04 ready!

Name Link
Latest commit a57c76ff8c2e52a73e1cb4cf488771a2e3c1ed55
Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/65ec0d0ea2ae8b0008e7e025
Deploy Preview https://deploy-preview-884--sunny-pastelito-5ecb04.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 09 '24 07:03 netlify[bot]

Deploy Preview for sunny-pastelito-5ecb04 ready!

Name Link
Latest commit 1511f82f26d52cbdac55c4b131b755645fe94266
Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/65f053f41975e30008de6486
Deploy Preview https://deploy-preview-884--sunny-pastelito-5ecb04.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 09 '24 07:03 netlify[bot]

@AlgirdasDubickas, we're closing this PR since it's stale. Please feel free to reopen it or create a new one in the future if you have a chance to work on this again - we really appreciate your contribution and would love to see it merged in the future!

tatiana avatar Jun 06 '24 21:06 tatiana