astronomer-cosmos icon indicating copy to clipboard operation
astronomer-cosmos copied to clipboard

[Bug fix] no test task on upstream only with detached test

Open okayhooni opened this issue 8 months ago • 2 comments

Description

  • Currently, should_detach_multiple_parents_tests=True incorrectly converts fully detached upstream nodes into task groups with non-functional test tasks
  • Modify the logic to ensure that an upstream node is not converted into a task group with unnecessary dbt-test task when all of its test tasks are detached.

Related Issue(s)

closes #1622

Breaking Change?

no

Checklist

  • [ ] I have made corresponding changes to the documentation (if required)
  • [ ] I have added tests that prove my fix is effective or that my feature works

okayhooni avatar Mar 18 '25 13:03 okayhooni

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
Latest commit d415440e8063cbbaac01de16b35eda1e62db827a
Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/67e1352c9738ee000864662c

netlify[bot] avatar Mar 18 '25 13:03 netlify[bot]

Hi @okayhooni did you have any chance of working on this further? We'll release Cosmos 1.10 on the 30th of April, and we'd love to have this bug fix included.

tatiana avatar Apr 22 '25 14:04 tatiana

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar May 23 '25 11:05 github-actions[bot]

This PR was closed because it has been inactive for 10 days since being marked as stale.

github-actions[bot] avatar Jun 02 '25 11:06 github-actions[bot]