astronomer-cosmos icon indicating copy to clipboard operation
astronomer-cosmos copied to clipboard

feature: implement TaskGroups by models folder

Open maximilianoarcieri opened this issue 9 months ago • 6 comments

Description

Implement grouping by folder structure in models folder.

Related Issue(s)

Closes https://github.com/astronomer/astronomer-cosmos/issues/1552

Breaking Change?

Yes (change DAG topology)

Checklist

  • [x] I have made corresponding changes to the documentation (if required)
  • [x] I have added tests that prove my fix is effective or that my feature works

maximilianoarcieri avatar Feb 27 '25 00:02 maximilianoarcieri

Deploy Preview for sunny-pastelito-5ecb04 ready!

Name Link
Latest commit 8232147497243923ac69b33bd1be3ace018af8bf
Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/6811efb546ef8700081b3d65
Deploy Preview https://deploy-preview-1566--sunny-pastelito-5ecb04.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 27 '25 00:02 netlify[bot]

Thank you for your reply @tatiana!

I changed the description to add that this is a breaking change like you said and I'll work on the feature to make it optional so users doesn't have problems with it. I'll also be making the corresponding changes to the tests and documentation.

I'm glad to know that you found it useful!

maximilianoarcieri avatar Mar 01 '25 16:03 maximilianoarcieri

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.37%. Comparing base (e31fc5b) to head (d73f728). Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1566   +/-   ##
=======================================
  Coverage   97.36%   97.37%           
=======================================
  Files          80       80           
  Lines        4934     4951   +17     
=======================================
+ Hits         4804     4821   +17     
  Misses        130      130           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 03 '25 10:03 codecov[bot]

Hi, @tatiana!

Do you have any other suggestion or advice for the feature?

It seems fine to me. I ran it with DbtDag and DbtTaskGroup using the variable in RenderConfig to make it optional and it works as expected.

maximilianoarcieri avatar Mar 03 '25 16:03 maximilianoarcieri

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Apr 06 '25 11:04 github-actions[bot]

We're very sorry for the delay, @maximilianoarcieri. We've been quite busy with Airflow 3 support and weren't able to give this PR the attention it deserves. We'll properly review it after the 1.10 release, and we can have Cosmos 1.11 alpha releases with this feature, so we can fully validate it.

tatiana avatar Apr 30 '25 13:04 tatiana