astro-sdk icon indicating copy to clipboard operation
astro-sdk copied to clipboard

Move benchmarking config out of codebase to GCS

Open utkarsharma2 opened this issue 2 years ago • 2 comments

Please describe the feature you'd like to see Currently, we have config kept in the Codebase due to which whenever we want to modify it we have to generate a new docker image.

Describe the solution you'd like We can move the config to GCS and load it from there. This way any mods to config won't affect the docker image.

Are there any alternatives to this feature? Open to suggestions.

Acceptance Criteria

  • [ ] While changing the config we should not generate a new docker image

utkarsharma2 avatar Sep 21 '22 12:09 utkarsharma2

When would we ever want to change the "benchmark config"?

kaxil avatar Sep 28 '22 22:09 kaxil

It doesn't make sense to have the config both on github and GCS.

sunank200 avatar Oct 11 '22 12:10 sunank200

Closing this as discussed with the team that it is not required anymore

phanikumv avatar Jan 16 '23 11:01 phanikumv