astro-sdk icon indicating copy to clipboard operation
astro-sdk copied to clipboard

Analyze methods for integrating SQL CLI to Astro CLI

Open tatiana opened this issue 1 year ago • 2 comments

Please describe the feature you'd like to see

As part of the SQL CLI 0.1, we need to make it available in the Astro CLI project.

There are at least two known ways of achieving this:

  • Override commands using the context feature
  • Expose a full standalone subcommand

Describe the solution you'd like We'd like to spike and understand these strategies and write a document with the pros and cons of each of them, proposing a path moving forward. We may want to consider a hybrid approach.

Acceptance criteria

  • [x] Spike on integrating our CLI using these two strategies (PoCs)
  • [x] An AEP similar to our table cleanup proposal documenting the pros and cons of each approach
  • [x] Collect feedback from the Astro CLI team, since the decision of how to integrate to the Astro CLI should be taken in a shared manner
  • [x] Have a decision on how we'll move forward.

tatiana avatar Sep 12 '22 13:09 tatiana

Created a document with the findings and shared it with the team: https://docs.google.com/document/d/1q6PsaWzjPWYIyI6twdnJVs3MV5Je-uzby2UW9UjNYSE/edit#

Once there is an agreement, I'll be creating a PR so the analysis and decision is part of the repo.

tatiana avatar Sep 26 '22 12:09 tatiana

@tatiana please, add the final version to the Github repo

tatiana avatar Oct 10 '22 14:10 tatiana

Isn't this complete? What are the pending items on this one?

kaxil avatar Oct 18 '22 20:10 kaxil

Just created a PR, moving the Google Doc into an AEP, @kaxil : https://github.com/astronomer/astro-sdk/pull/1126

tatiana avatar Oct 21 '22 00:10 tatiana