astro-sdk icon indicating copy to clipboard operation
astro-sdk copied to clipboard

Published 20 hours ago • verified publisher icon astronomer

Enable Pylint

Open kaxil opened this issue 3 years ago • 4 comments
trafficstars

kaxil avatar Apr 04 '22 23:04 kaxil

Ran the following before (https://github.com/astronomer/astro-sdk/commit/04f309d) and after refactor (commit: https://github.com/astronomer/astro-sdk/commit/f8ddf8b8bc8ce0992ef9b85065e8d2d3e1a9df45)

❯ pylint src -r y -f colorized --max-line-length=110

Before refactor: Your code has been rated at 6.42/10 After refactor: Your code has been rated at 8.54/10 (previous run: 6.42/10, +2.12)

kaxil avatar Jun 09 '22 19:06 kaxil

From my experience with Airflow I don't really like pylint 😅. If you want to have a rating for your code, GitHubs native LGTM would be a great option.

feluelle avatar Aug 16 '22 08:08 feluelle

That's a good point about LGTM tool

kaxil avatar Aug 18 '22 20:08 kaxil

LGTM.com will be shut down in December 2022 — we recommend that you use GitHub code scanning instead.

Okay then we just use GitHub code scanning instead.

feluelle avatar Aug 19 '22 05:08 feluelle