astro-sdk icon indicating copy to clipboard operation
astro-sdk copied to clipboard

Refactor the way to add databases to each test

Open sunank200 opened this issue 1 year ago • 0 comments

Describe the bug More details: https://github.com/astronomer/astro-sdk/pull/1695#discussion_r1093828602

By looking at how many places you had to make this type of change, I was wondering if we could, by any chance, try to compute things using SUPPORTED_DATABASES: https://github.com/astronomer/astro-sdk/blob/main/python-sdk/src/astro/constants.py#L70

So we don't need the list hard-coded in so many tests. If we managed to get this to work, it would be much easier to add future databases, since we wouldn't need to update as many tests

sunank200 avatar Feb 06 '23 06:02 sunank200