astro-sdk icon indicating copy to clipboard operation
astro-sdk copied to clipboard

Tracking ticket for smart_open() - wasb support

Open utkarsharma2 opened this issue 1 year ago • 2 comments

Please describe the feature you'd like to see In our code base, we should remove the following lines of code: https://github.com/astronomer/astro-sdk/blob/ba25f0c8bb7ab0a3e7d2873228bad9b36e7305e1/python-sdk/src/astro/files/locations/azure/wasb.py#L47-L61

once the ticket is resolved on smart open end - https://github.com/RaRe-Technologies/smart_open/issues/755

Describe the solution you'd like We should change it back to location.path

Are there any alternatives to this feature? Is there another way we could solve this problem or enable this use-case?

Acceptance Criteria

  • [ ] All checks and tests in the CI should pass
  • [ ] Unit tests (90% code coverage or more, once available)
  • [ ] Integration tests (if the feature relates to a new database or external service)
  • [ ] Example DAG
  • [ ] Docstrings in reStructuredText for each of methods, classes, functions and module-level attributes (including Example DAG on how it should be used)
  • [ ] Exception handling in case of errors
  • [ ] Logging (are we exposing useful information to the user? e.g. source and destination)
  • [ ] Improve the documentation (README, Sphinx, and any other relevant)
  • [ ] How to use Guide for the feature (example)

utkarsharma2 avatar Jan 10 '23 10:01 utkarsharma2