astro-sdk icon indicating copy to clipboard operation
astro-sdk copied to clipboard

Add open lineage support for MergeOperator

Open sunank200 opened this issue 1 year ago • 2 comments

Description

What is the current behavior?

Open Lineage support for MergeOperator is missing.

closes: #900

What is the new behavior?

  • Add open Lineage support for MergeOperator
  • Add the test for the same

Does this introduce a breaking change?

No

Checklist

  • [x] Created tests which fail without the change (if possible)
  • [x] Extended the README / documentation, if necessary

sunank200 avatar Oct 14 '22 14:10 sunank200

Codecov Report

Base: 94.32% // Head: 94.38% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (6d99b07) compared to base (6a857c0). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
+ Coverage   94.32%   94.38%   +0.05%     
==========================================
  Files          63       63              
  Lines        2785     2812      +27     
  Branches      309      311       +2     
==========================================
+ Hits         2627     2654      +27     
  Misses        106      106              
  Partials       52       52              
Impacted Files Coverage Δ
python-sdk/src/astro/lineage/extractor.py 100.00% <100.00%> (ø)
python-sdk/src/astro/lineage/facets.py 100.00% <100.00%> (ø)
python-sdk/src/astro/sql/operators/merge.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 14 '22 14:10 codecov[bot]

LGTM

pankajastro avatar Oct 14 '22 15:10 pankajastro

@sunank200 to fix the test look like you will have to pass context having ti here https://github.com/astronomer/astro-sdk/blob/main/python-sdk/tests/sql/operators/test_merge.py#L297 something like https://github.com/astronomer/astro-sdk/blob/main/python-sdk/tests/sql/operators/test_append.py#L81

pankajastro avatar Oct 17 '22 06:10 pankajastro

Add context to the task in test

yup https://github.com/astronomer/astro-sdk/pull/1068/commits/224e4de4d8fed82f8b3f9f38426c205d9c5efa57

sunank200 avatar Oct 17 '22 07:10 sunank200