astro-sdk icon indicating copy to clipboard operation
astro-sdk copied to clipboard

Add Config and Table params in run.sh script

Open utkarsharma2 opened this issue 3 years ago • 0 comments

Please describe the feature you'd like to see Currently,

  1. We are passing the benchmarking table via the env variable.
  2. The config used for benchmarking is hardcoded in the code.

Describe the solution you'd like We can add parameters in run.sh to accept config and table.

Acceptance Criteria

  • [ ] All checks and tests in the CI should pass
  • [ ] Unit tests (90% code coverage or more, once available)
  • [ ] Integration tests (if the feature relates to a new database or external service)
  • [ ] Example DAG
  • [ ] Docstrings in reStructuredText for each of methods, classes, functions and module-level attributes (including Example DAG on how it should be used)
  • [ ] Exception handling in case of errors
  • [ ] Logging (are we exposing useful information to the user? e.g. source and destination)
  • [ ] Improve the documentation (README, Sphinx, and any other relevant)
  • [ ] How to use Guide for the feature (example)

utkarsharma2 avatar Oct 06 '22 14:10 utkarsharma2