astro-cli icon indicating copy to clipboard operation
astro-cli copied to clipboard

Add a little flair to the Root cmd (Astronomer astro-cli splash screen)

Open alex-astronomer opened this issue 3 years ago โ€ข 5 comments

Description

Adds an Astro-CLI splash screen to the root cmd.

๐Ÿงช Functional Testing

Purely aesthetic.

๐Ÿ“ธ Screenshots

image

๐Ÿ“‹ Checklist

  • [x] Rebased from the main (or release if patching) branch (before testing)
  • [x] Ran make test before taking out of draft
  • [x] Ran make lint before taking out of draft
  • [x] Added/updated applicable tests
  • [x] Tested against Astro-API (if necessary).
  • [x] Tested against Houston-API and Astronomer (if necessary).
  • [x] Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • [x] Updated any related documentation

alex-astronomer avatar Jun 01 '22 21:06 alex-astronomer

Codecov Report

Base: 86.99% // Head: 87.00% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (1e4b168) compared to base (929fc0f). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   86.99%   87.00%   +0.01%     
==========================================
  Files          97       97              
  Lines        8251     8259       +8     
==========================================
+ Hits         7178     7186       +8     
  Misses        631      631              
  Partials      442      442              
Impacted Files Coverage ฮ”
cmd/root.go 96.61% <100.00%> (+0.53%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 01 '22 21:06 codecov[bot]

Astronaut could probably be a little more centered... Going to work on getting that squared up

alex-astronomer avatar Jun 02 '22 11:06 alex-astronomer

@paolaperaza @jwitz

sunkickr avatar Jul 01 '22 18:07 sunkickr

Had it pretty good the first time! One space off from center :D

alex-astronomer avatar Jul 01 '22 19:07 alex-astronomer

Are we good to merge this or is there anything pending in here? cc @alex-astronomer @sunkickr

neel-astro avatar Jul 20 '22 12:07 neel-astro

@alex-astronomer We are moving away from the astronomy analogy. Hence removing the astronaut from the splash screen ๐Ÿ˜•

kushalmalani avatar Sep 28 '22 17:09 kushalmalani

No worries, what's the reason for that? I thought Astronomer and Astro was like directly related to space lol not trying to be sassy just curious.

alex-astronomer avatar Oct 02 '22 23:10 alex-astronomer

I think its just a product decision. @sunkickr Do you remember what was the reason?

kushalmalani avatar Oct 02 '22 23:10 kushalmalani