astro-cli icon indicating copy to clipboard operation
astro-cli copied to clipboard

Feature/homebrew trigger

Open bote795 opened this issue 4 years ago โ€ข 5 comments

Description

configuration to try to test creating a pre-release and release approval ci jobs that when we want to do a pre-release it will update it as such and then on release it will update pre-release to release and release to homebrew

๐ŸŽŸ Issue(s)

Related astronomer/issues#3480

๐Ÿงช Functional Testing

List the functional testing steps to confirm this feature or fix.

๐Ÿ“ธ Screenshots

Add screenshots to illustrate the validity of these changes.

๐Ÿ“‹ Checklist

  • [ ] Rebased from the main (or release if patching) branch (before testing)
  • [ ] Ran make test before taking out of draft
  • [ ] Added/updated applicable tests
  • [ ] Tested against Houston-API and Astronomer (if necessary).
  • [ ] Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • [ ] Updated any related documentation

bote795 avatar Sep 24 '21 21:09 bote795

Need to figure out how to test this? @danielhoherd any idea how to test this without doing a release?

bote795 avatar Sep 24 '21 21:09 bote795

@bote795 you could make a new repo and play with it there. Maybe fork this repo to your personal account?

danielhoherd avatar Sep 27 '21 22:09 danielhoherd

@bote795 / @danielhoherd you can always switch to --skip-publish link:

goreleaser release --skip-publish

andriisoldatenko avatar Oct 14 '21 23:10 andriisoldatenko

@bote795 / @danielhoherd you can always switch to --skip-publish link:

goreleaser release --skip-publish

well with current behavior we skip but the point of this pr is to have approval jobs one for pre-release and one for real release and for it to update homebrew repo as well..but i haven't been able to get ci configuration on my personal to be able to test this...there wouldn't really be any harm to merge and test in release branches since before we were already undoing the release manually

bote795 avatar Oct 15 '21 15:10 bote795

@neel-astro do we still need this? can you please review and may be continue work?

andriisoldatenko avatar Feb 10 '22 10:02 andriisoldatenko

closing this PR, as we currently plan to add more package manager support to CLI, so will tackle this problem once that is done

neel-astro avatar Sep 28 '22 17:09 neel-astro