astro-cli icon indicating copy to clipboard operation
astro-cli copied to clipboard

Always `--pull` when building image

Open jedcunningham opened this issue 2 years ago • 4 comments

  • [x] I have checked that a similar feature request does not already exist.

✍️ Is your feature request related to a problem? Please describe.

We'd like to start offering floating tags for Runtime (e.g. a astro-runtime:9) which will always point to the latest release in a given major. One challenge, however, is to make sure the latest image is used when building the image.

🧩 Describe the solution you'd like

Add --pull to the build command.

🤔 Describe alternatives you've considered

We could alternatively document customers need to do an explicit pull before an astro deploy etc, but that seems easy to forget and not very polished. One extra request to make sure the image is up to date is pretty cheap (locally, typically .1 second or so).

Is your feature request specific to a particular Astronomer Platform?

  • [ ] Astro
  • [ ] Software
  • [x] None/Unknown

jedcunningham avatar Oct 02 '23 15:10 jedcunningham

@vishwas-astro @nicholasfilippi - I see this is in icebox. Is this something we can prioritize please? This is a blocker for us publishing runtime images with floating tags for major runtime versions.

If someone uses this batch of images, patch and minor runtime updates will happen automatically. If we don't change the pull method when building, docker will not check whether or not we have published a more recent version and will default to whatever is in the cache - meaning no automatic update.

cmarteepants avatar Oct 03 '23 17:10 cmarteepants

does this fix the issue? https://github.com/astronomer/astro-cli/pull/1415

sunkickr avatar Oct 12 '23 18:10 sunkickr

I think so - @melugoyal @jedcunningham ?

cmarteepants avatar Oct 17 '23 15:10 cmarteepants

Yes it does.

jedcunningham avatar Oct 17 '23 16:10 jedcunningham