ap-airflow icon indicating copy to clipboard operation
ap-airflow copied to clipboard

add analytics plugin

Open aliotta opened this issue 2 years ago • 2 comments

What this PR does / why we need it: Adds an airflow plugin that adds an api that enables houston to pull data on airflow task usage data.

It also adds a page linked in the airflow top nav that allows user to hit the endpoint via a form.

Related Issue(s)

https://github.com/astronomer/issues/issues/5110

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [ ] If changing an existing image, please add an applicable test in .circleci/bin/test-airflow-image.py

aliotta avatar Oct 12 '22 20:10 aliotta

Any thoughts on whether this PR needs tests and what I would test for if so?

In the equivalent astro-runtime PR (https://github.com/astronomer/astro-runtime/pull/470/files#diff-71f1f738529da43a88a8cf631127bb4c13f0e956eebba4d0b7a9f4fe16563732R485) I have a test that hits the webserver endpoint we expose. But I'm not sure if I'm able to hit the api endpoints in this test suite as I don't see any examples of that yet.

aliotta avatar Oct 12 '22 20:10 aliotta

I ran 2.1.4 locally and did verify the plugin installed correctly.

aliotta avatar Oct 12 '22 20:10 aliotta

If the HTML page of the plugin is going to be visible to end users, it might be a good idea to fix/clean/style it up a bit. But otherwise I think this is okay to merge.

@blag Have removed the nav item in the 1.0.2 release and updated the PR with the new release version

rishkarajgi avatar Nov 28 '22 17:11 rishkarajgi