airflow-provider-great-expectations icon indicating copy to clipboard operation
airflow-provider-great-expectations copied to clipboard

SQL Alchemy dependencies issue

Open itaise opened this issue 1 year ago • 4 comments

Hi, We have a dependency conflict when using the provider package.

Starting from Airflow 2.3.3, the Airflow constraints file requires Sql Alchemy 1.4.27 while the great expectations provider requires a version earlier than 1.4.10.

Can someone please advice? Is this requirement planned to be changed? Thanks a lot!

itaise avatar Aug 14 '22 13:08 itaise

Yeah. I think the limitation is because we used to have the limitation in Airlfow (the problem was that we had mssql compatibility problem), but unless there is a good reason why it's there, it's likely not needed (the problem has been solved since in sqlalchemy and removed in airflow: https://github.com/apache/airflow/commit/0853d60f16b45472ebac83bcb4fb6de112c90d6b

And unlesss there was a good reason for Great Expectations to add the limit, this upper-bound limit should not be there in the first place (it's an airlfow problem not GE problem and limit in airflow was already limiting it.

potiuk avatar Aug 14 '22 20:08 potiuk

Thank you @potiuk! How would you recommend going about solving it? Should I open a PR with the upper bound removed?

itaise avatar Aug 15 '22 08:08 itaise

It's a matter of Great Expectations maintainers (I am not one of them) - but yeah, that's what I'd do :)

potiuk avatar Aug 15 '22 10:08 potiuk

@talagluck maybe you can advise? thanks a lot!

itaise avatar Aug 15 '22 10:08 itaise

Solved by https://github.com/great-expectations/airflow-provider-great-expectations/pull/55 @itaise we can close this issue. Thanks @talagluck for helping quickly

eladkal avatar Aug 28 '22 07:08 eladkal