airflow-chart icon indicating copy to clipboard operation
airflow-chart copied to clipboard

Published 20 hours ago • verified publisher icon astronomer

Add JSON Schema file

Open thmzlt opened this issue 3 years ago • 3 comments

Description

For now, we are interested in checking that all OSS chart values are correctly namespaced under the airflow top-level property, so we declare all top-level properties and set additionalProperties to false.

🎟 Issue(s)

Resolves astronomer/issues#3715

📋 Checklist

  • [ ] The PR title is informative to the user experience
  • [ ] Functional test(s) added
  • [ ] Helm chart unit test(s)

thmzlt avatar Nov 03 '21 17:11 thmzlt

While it makes sense to have a JSON schema defined in this repo this does not solve the use case we were looking to resolve. Specifically we wanted a solution that would inform our enterprise users that they have an issue in their environment variables at the time of the upgrade of their platform. The way to solve this is to have a very similar schema file to this defined in the astronomer/astronomer repo.

aliotta avatar Nov 05 '21 15:11 aliotta

@aliotta: https://github.com/astronomer/astronomer/pull/1270

thmzlt avatar Nov 05 '21 17:11 thmzlt

@jedcunningham @aliotta what's the status here? Thomaz isn't around to finish this. Do we want to finish this effort or abandon it?

danielhoherd avatar Mar 14 '22 22:03 danielhoherd