Anemone3DS icon indicating copy to clipboard operation
Anemone3DS copied to clipboard

assemble a splash preview if none was found

Open Jan200101 opened this issue 2 years ago • 5 comments

generates a preview for splash screens if no suitable preview.png was found

Code is very ugly right now because the core preview drawing code expects to deal with a single texture instead of two, one for each screen and some of the code smells funny.

I welcome suggestions from other contributors and maintainers into how this would be best implemented to be compatible with the current architecture, that isn't just converting splash screens to pngs.

Here are some zip files to test every combination of events out Preview.zip NoPreview.zip NoTop.zip NoBottom.zip NoNothing.zip

Jan200101 avatar Oct 01 '22 16:10 Jan200101

reworked the previewing code to deal with raw agbr buffers instead of the contents of png files

so instead of doing bin -> rgba -> png -> agbr -> texture png -> agbr -> texture

we now do

bin -> agbr -> texture png -> agbr -> texture

this removes the overhead when generating a preview from the splash binaries and would simplify changes or additions to the previewing code (like moving to a different preview file format or generating theme previews)

Jan200101 avatar Oct 02 '22 14:10 Jan200101

rebased onto master because compilation was borked :/

might or might not work still, untested

Jan200101 avatar Feb 27 '24 13:02 Jan200101

Looks good - I'll merge once I've tested

astronautlevel2 avatar Feb 27 '24 14:02 astronautlevel2

needs #296 to build

Jan200101 avatar Feb 27 '24 19:02 Jan200101

Tested on my New 2DS XL

Preview.zip (has preview.png)

IMG_20240227_205820.jpg

NoPreview.zip (no preview.png, only splash .bin's )

IMG_20240227_205813.jpg

NoTop.zip (no preview.png, only splashbottom.bin)

IMG_20240227_205826.jpg

NoBottom.zip (no preview.png, only splash.bin)

IMG_20240227_205834.jpg

NoPreview.zip (no preview.png, no splash bin)

IMG_20240227_205842.jpg

the splash images are a test pattern generated from this script https://github.com/Jan200101/3ds-splash/blob/master/generate_splash.py

I also tested a real theme

New 3DS XL Neon (preview.png removed)

link

IMG_20240227_205850.jpg

Jan200101 avatar Feb 27 '24 20:02 Jan200101