i18n icon indicating copy to clipboard operation
i18n copied to clipboard

Take trailing slash into account

Open florian-lefebvre opened this issue 1 year ago • 4 comments

florian-lefebvre avatar May 10 '24 11:05 florian-lefebvre

Hi there, shot in the dark, but right now I don't get my language when I browser to /fr only when I go to /fr/.

image

Would this related to this bug?

nojaf avatar Jun 10 '24 19:06 nojaf

mmh I'm not sure because you don't have a special trailingSlash configuration. Would you mind providing a minimal reproduction? (in a repository, there are issues with Stackblitz)

florian-lefebvre avatar Jun 11 '24 05:06 florian-lefebvre

This is what I have so far: https://github.com/nojaf/astro-translations-repro

nojaf avatar Jun 11 '24 06:06 nojaf

Having the same issue, cannot get locales to load for /mk only for /mk/. Also, looks like it is the same behaviour in the Demo app.

If can be made so that it recognizes the locale without the trailing slash, would be awesome 🙏

dsijakovski98 avatar Jul 29 '24 23:07 dsijakovski98

Same as above. It only loads the default locale's translations if you have trailingSlash set to e.g. never. Would be great to get this fixed 🙏

amosbastian avatar Sep 03 '24 11:09 amosbastian

If someone wants to contribute this fix, please do! I don't have near plans to address it

florian-lefebvre avatar Sep 03 '24 15:09 florian-lefebvre

Sounds reasonable, any pointers or steps on how one would debug or run this locally?

nojaf avatar Sep 04 '24 07:09 nojaf