astroid icon indicating copy to clipboard operation
astroid copied to clipboard

Expand & navigate thread in thread-index

Open mturquette opened this issue 7 years ago • 7 comments
trafficstars

The default search view in astroid sort of mimics the Gmail interface: a single row showing a thread. One improvement over Gmail is that astroid captures the whole thread, including reply-to'd emails with different Subject lines, as is common when email patch sets to a mailing list. So far, so good.

One feature enhancement that would be really great is to expand the thread from within the search view and show each mail in that thread as a single row/line including the author and subject line. When expanded this tree of mails could be navigated with j and k and pressing enter would open the thread focused on that specific mail.

Inspiration for this feature comes from mutt and alot. I'm still really happy with astroid, but I have actually stopped using it for very large threads (e.g. series of 20 or more patches and corresponding replies that review those patches). The monolithic "scroll one mail at a time" mode is just really slow for me when I can't easy jump around a thread of patches with unique Subject lines.

Pretty please? Thanks!

mturquette avatar Mar 12 '18 00:03 mturquette

Somewhat related: is there a way to sort the mail by the reply-to chain instead of chronologically? When doing patch review on a multi-patch series it does not make sense to have replies to the various patches all mixed in together. Screenshot to illustrate:

screenshot 2018-03-11 17 53 42

You can see there are are replies to patch 7/8, then 0/8 (the coverletter) followed by more replies to patch 4/8. When I'm trying to review a single patch it would be desirable to have all replies to that one patch lined up in the UI.

mturquette avatar Mar 12 '18 00:03 mturquette

Hi, related issues: #398, #269, #250, #100 (duplicate of this?), #180.

You can have messages be indented, then it is easier to see which patches belong together. Do you already know about the paned view? This would work good together with a tree-view (#100), for quickly reviewing a long thread.

gauteh avatar Mar 12 '18 08:03 gauteh

We are already detecting the messages in the thread based on different subjects (I think it was to show the subject in the preview), it would be easy to jump to the next/prev message with different subjects... not sure if this is useful or just confusing.

gauteh avatar Mar 12 '18 08:03 gauteh

I searched for info on paned_view and came up short. Saw some references in the code to something like a horizontal split, but nothing in the configuration for how to use it. Any hints? I'm happy to update the wiki with the info.

mturquette avatar Mar 15 '18 05:03 mturquette

Michael Turquette writes on mars 15, 2018 6:44:

I searched for info on paned_view and came up short. Saw some references in the code to something like a horizontal split, but nothing in the configuration for how to use it. Any hints? I'm happy to update the wiki with the info.

In thread-index: Use Alt-Enter to open in pane, and Alt-Space to swap focus between panes.

gauteh avatar Mar 15 '18 07:03 gauteh

Michael Turquette writes on mars 15, 2018 6:44:

Any hints? I'm happy to update the wiki with the info.

Great if you update the wiki!

gauteh avatar Mar 15 '18 07:03 gauteh

Michael Turquette writes on mars 15, 2018 6:44: I searched for info on paned_view and came up short. Saw some references in the code to something like a horizontal split, but nothing in the configuration for how to use it. Any hints? I'm happy to update the wiki with the info. In thread-index: Use Alt-Enter to open in pane, and Alt-Space to swap focus between panes.

Unfortunately can't get pane to work anymore, see issue #547

Zebrazilla avatar Nov 01 '18 16:11 Zebrazilla