Thomas Robitaille

Results 891 comments of Thomas Robitaille

Ok new MWE: ```python import numpy as np from astropy.wcs import WCS from astropy.coordinates import SkyCoord, SpectralCoord wcs = WCS(naxis=3) wcs.wcs.ctype = 'RA---HPX', 'DEC--HPX', 'FREQ-LOG' wcs.wcs.crval = 0, 0, 1e-18...

Mark Calabretta has a fix for this which will likely be included in the next version of WCSLIB

We should probably include a regression test for this but we can do it in a separate PR

Coming back to this I don't fully understand why the suggested change would work any better since instead of checking isinstance we now check for exact match then for isinstance,...

@neutrinoceros just to check, did you forget to paste the error?

@neutrinoceros - could you rebase this so that it picks up the multiple limited API CI jobs?

@mcara @nden - just to check, would either of you have time in the near future to review this? Or would you be happy for others to review/approve if ready?

@mcara @nden - this should be merged before my preserve_units PR, happy to rebase mine

This is a subtle bug in the example you posted - ``set_axislabel_position`` does not take e.g. ``right`` or ``left`` - but one character per axis you want to show it...