Thomas Robitaille
Thomas Robitaille
:laughing:
@kakirastern - this is not an easy issue, I need to discuss it a little more with the people that asked for it to determine how they would want it...
I'll try reviewing this soon, but in the mean time, could you fix the code style issues and also add a regression test that would normally have failed due to...
When the affine transformation contains a translation things don't work quite right so need to investigate some more.
@dhomeier - just FYI I've now pushed changes here to fix the translation stuff, and I've also simplified the API to have a single 'rotation' on the viewer state instead...
I think glue doesn't yet work well with WCSes that have a different number of pixel and world dimensions - see https://github.com/glue-viz/glue/issues/2162
@Morisset - indeed! Would you be interested in opening a pull request to fix this?
In terms of procedure, let's consider this the main issue since it's where most of the code has to be changed. But I just opened https://github.com/glue-viz/glue-jupyter/issues/155 to remind us to...
Maybe just bumping the min version is fine if everything else seems to work
The GitHub API allows you to access the contributor list with stats directly btw: https://developer.github.com/v3/repos/statistics/#contributors So one would not need to actually look at the full git commit history.