socksify-ruby icon indicating copy to clipboard operation
socksify-ruby copied to clipboard

Published 20 hours ago • verified publisher icon astro

Net::HTTP.SOCKSProxy auth support, take 2

Open musybite opened this issue 7 years ago • 12 comments

This MR is inspired by #24, but does not use thread-local variables to store username/password. This is IMO safest and cleanest way to do it.

musybite avatar Mar 13 '18 20:03 musybite

Hi, I'd like to see this in a socksify release so I can use it in Faraday. I don't personally use a SOCKS proxy, but I have successfully tested it in my integration suite with Faraday and a golang socks server.

Is there any way I can help get this out?

/cc Integration test suite PR: https://github.com/technoweenie/faraday-live/pull/7 /cc Faraday PR: https://github.com/lostisland/faraday/pull/992

technoweenie avatar Jun 13 '19 17:06 technoweenie

is this good to go?

guivinicius avatar Dec 03 '19 14:12 guivinicius

Same question as @guivinicius : what is preventing this PR from being merged for so long ?

gcolson avatar Jul 13 '20 09:07 gcolson

Is there anything we can do to move this forward?

iMacTia avatar Oct 14 '20 16:10 iMacTia

Is that dead?

top4ek avatar Nov 06 '21 07:11 top4ek

Who wants to become maintainer?

astro avatar Mar 21 '22 11:03 astro

@astro if you are still looking for a maintainer for socksify I'm happy to give it a go.

MatzFan avatar Jun 24 '22 14:06 MatzFan

@MatzFan Thanks. Please be kind to my baby. ;-)

astro avatar Jun 24 '22 16:06 astro

With 40M downloads from rubygems.org I could hardly do otherwise :-)

MatzFan avatar Jun 24 '22 16:06 MatzFan

Oh, I was not aware.

In that case I would like to read all changes before publishing to rubygems.org. Please ping me whenever you tag a release.

astro avatar Jun 25 '22 00:06 astro

@astro sure, will do.

MatzFan avatar Jun 25 '22 01:06 MatzFan

Can this be merged? Works well.

basex avatar Sep 19 '22 17:09 basex