microvm.nix icon indicating copy to clipboard operation
microvm.nix copied to clipboard

chore: replace hostName with fqdnOrHostName

Open felbinger opened this issue 2 months ago • 7 comments

Using fully qualified domain names as unique identifier for containers improves identification of containers on large (potentially multi tenant) hypervisors.

In the current version using a container name containing a dot doesn't work. I forked microvm.nix and adjusted it so that fqdn's are used by default.

Should we try to upstream this? If yes how?

I drafted this change because merging this would result in breaking changes if networking.domain is being set for a machine.

felbinger avatar Oct 19 '25 21:10 felbinger

I haven't had the time to test yet, will do in the next days...

felbinger avatar Oct 20 '25 21:10 felbinger

I haven't had the time to test yet, will do in the next days...

Ok works. Now this change works without breaking changes if networking.domain is NOT set.

If I am correct, systems that have a domain set will still encounter breaking changes, right?

How should we proceed?

felbinger avatar Oct 21 '25 16:10 felbinger

@astro how do we could handle this?

SuperSandro2000 avatar Oct 29 '25 00:10 SuperSandro2000

Also the CI tests are failing for some reason I did not grasp yet.

SuperSandro2000 avatar Oct 29 '25 01:10 SuperSandro2000

rebased with main and removed irrelevant comment i created while making the initial change

felbinger avatar Nov 25 '25 13:11 felbinger

Why not add an option for the microvm name that defaults to networking.hostName and which you can change to something else like fqdn?

SuperSandro2000 avatar Dec 13 '25 21:12 SuperSandro2000

Why not add an option for the microvm name that defaults to networking.hostName and which you can change to something else like fqdn?

Works for me, if that's the way to get this change into microvm

felbinger avatar Dec 13 '25 22:12 felbinger