astro
cloud-hypervisor: add platformOEMStrings and extraPlatformOpts.
The cloud-hypervisor command line interface unfortunately doesn't support multiple instances of the same arg with a different value, so we have to resort to these extra module options rather than using extraArgs.
To make matters even worse, the --platform argument (of which there can be
only one), is overloaded with different types of sub-args that also need to be
provided multiple times.
This commit allows the operator to add oem strings (for example to pass systemd credentials), as well as raw platform options as needed.
NixCI is ready to run on this PR.
Maintainer: Comment nix-ci run to run now.
![nix-ci-app[bot] avatar](https://avatars.githubusercontent.com/in/361795?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi again @astro, I want to pick this little project back up.. so I'm going to be reviving these PRs today :) Please see my comments to your comments!.
I've just pushed new commits that should address your concerns.
[!NOTE]
I added the refactor as a new commit, but I expect this to be squashed during the merge with the newest commit's commit message. I wanted to keep the old extraPlatformOpts around in case we changed our minds.
@SuperSandro2000 I've pushed a new commit that rebases onto main to pickup your latest PR, and also addresses your comments. Let me know if there is anything else.
