lib/runner: add macvtap config checks

Open astro opened this issue 1 year ago • 2 comments

@inhumantsar Does this solve #284?

Oct 13 '24 01:10 astro

I've stepped away from the computer for the evening but that looks like it would do the trick! I'll give it a try tomorrow or Monday and let you know.

Thanks!

Oct 13 '24 02:10 inhumantsar

Please test, I don't use macvtap myself but tap and sr-iov.

Oct 15 '24 17:10 astro

This is no longer required as the macvtap options are no longer types.nullOr. Their missing default does no longer cause an error when they're not used in case of type != "macvtap". Was there an improvement in the NixOS module system?

Dec 03 '24 21:12 astro