s2fft icon indicating copy to clipboard operation
s2fft copied to clipboard

Body of argument check for Trapani recursions commented out

Open matt-graham opened this issue 9 months ago • 0 comments

In

https://github.com/astro-informatics/s2fft/blob/ea118328bb80d44a0b57fff73b3bee372ffc5025/s2fft/recursions/trapani.py#L776-L792

the entire body of the function is commented out. I suspect this may be something to do with the assert statements not working correctly within a JAX JIT compiled function due to needing to know the concrete shapes of arrays given the commenting out was done in the changes in https://github.com/astro-informatics/s2fft/commit/3b514f173ee116cbe5ae4c0a2dcb35f6dea79a3b adding JAX implementation by @jasonmcewen. We should either remove the function if no longer required or update to make it work if the issue is with JAX JIT transform.

matt-graham avatar Feb 13 '25 10:02 matt-graham