stdeb icon indicating copy to clipboard operation
stdeb copied to clipboard

Initial attempt at GitHub Actions based CI.

Open nuclearsandwich opened this issue 1 year ago • 2 comments

Travis has long since ceased being a viable CI platform for open source projects. It's a pain to bake so heavily into yet another platform but at least it is right here. I've had some success in other projects using https://earthly.dev to allow the same config to run locally and in CI so wrapping that in GitHub actions may lower the barrier to local testing for future contributors. For now I just want some CI feedback.

The use of ruff instead of flake8 is entirely a curiosity since I haven't used before and I'm not at all committed to it.

nuclearsandwich avatar Jul 04 '24 00:07 nuclearsandwich

test.sh is passing as of adb365bc26ba85496c02b1c0d80fb9d53aa3891c. Progress!

nuclearsandwich avatar Jul 09 '24 01:07 nuclearsandwich

We're green! (with lowered standards). I am going to take a shot at updating the Vagrantfiles alongside the addition of earthly but I'm tempted to go ahead with this even if it only contributes to my own maintenance of this package.

nuclearsandwich avatar Jul 09 '24 02:07 nuclearsandwich

  • Looking into the platforms supported by travis before, the ppc64le was an option, not sure if we can include it in the new setup or it was a conscious decision to remove it.

Good point. It wasn't conscious but I also don't know that there needs to be specific support for it in this pure-python package. It looks like Earthly can work with multi-platform docker images although I got some strange errors when trying it.

I'll consider looking at it more in the future but for the sake of getting some CI running I won't block on it.

nuclearsandwich avatar Nov 14 '24 19:11 nuclearsandwich

  • The lint action succeeded but seems to have a couple of errors from ruff:

Yeah, I think the errors are because there is Python 2 and 3-compatible syntax in use that ruff isn't okay with. So I can't fully enable the linters until Python 2 support is dropped in #198.

nuclearsandwich avatar Nov 14 '24 19:11 nuclearsandwich