uv icon indicating copy to clipboard operation
uv copied to clipboard

Allow discovery of interpereters in virtual environments activated by a shim

Open zanieb opened this issue 1 year ago • 5 comments

Closes https://github.com/astral-sh/uv/issues/4009 Closes https://github.com/astral-sh/uv/issues/2109

zanieb avatar Jun 05 '24 00:06 zanieb

Considering if this is the correct approach still. We should also test with the pyenv-virtualenv shim.

zanieb avatar Jun 05 '24 00:06 zanieb

I find this implementation awkward as I only want this to be used if it's a virtual environment interpreter but we can't easily enforce that in python_executables. I'll probably poke at a better implementation.

zanieb avatar Jun 05 '24 00:06 zanieb

I'd appreciate input on a better approach here.

zanieb avatar Jun 06 '24 12:06 zanieb

Just confirming: still relevant to review? I know there was some back-and-forth on the issue but didn't read it deeply.

charliermarsh avatar Jun 08 '24 18:06 charliermarsh

@charliermarsh yeah this is still necessary if we want to support detecting virtual environments that are only activated by an executable shim. I'm not in love with the implementation though.

zanieb avatar Jun 08 '24 18:06 zanieb