uv icon indicating copy to clipboard operation
uv copied to clipboard

Flaky expect failures in resolver

Open hauntsaninja opened this issue 1 year ago • 1 comments

Getting the following segfault:

thread 'main' panicked at crates/uv-resolver/src/resolution.rs:135:30:
Every package should have metadata

Repro:

In [5]: Counter(subprocess.run("rm -rf .venv; uv venv --seed; uv pip install --no-cache --link-mode=copy --no-deps gpustat==1.1.1", shell=True).returncode for _ in range(100))
Out[5]: Counter({101: 73, 0: 27})

https://github.com/astral-sh/uv/pull/1583 should improve the error message (I had to do some bisection to narrow it down to a single package)

With #1583 it appears there's some connection to setuptools-scm

Similar message reported in this comment: https://github.com/astral-sh/uv/issues/1484#issuecomment-1948863469

hauntsaninja avatar Feb 17 '24 12:02 hauntsaninja

Awesome, thanks! Will fix.

charliermarsh avatar Feb 17 '24 12:02 charliermarsh

I can reproduce this on some old commits (I randomly tried c1eb6130e1cb46a7ce5c34bccdfcb9245e29e8a8), but not on main, so I think it's resolved, at least on main? Will re-open if not.

charliermarsh avatar Feb 21 '24 14:02 charliermarsh

Thank you! I bisected the fix commit to #1607 , hopefully there's something in there that explains the formerly non-deterministic behaviour

hauntsaninja avatar Feb 21 '24 20:02 hauntsaninja