uv icon indicating copy to clipboard operation
uv copied to clipboard

include testing on amazonlinux:2023

Open altendky opened this issue 6 months ago • 8 comments

Trying to test related to https://github.com/astral-sh/uv/issues/1532.

altendky avatar Feb 16 '24 19:02 altendky

This LGTM, but I'll defer to @charliermarsh or @zanieb on whether we want to add new CI jobs.

BurntSushi avatar Feb 16 '24 19:02 BurntSushi

If it is wanted, I can bother to make it actually work. Or you can go ahead and close it.

altendky avatar Feb 16 '24 19:02 altendky

CI is kind of expensive, I'm hesitant to add more jobs. We'll talk about this some more though.

zanieb avatar Feb 16 '24 20:02 zanieb

Not a big deal to me, just figured I'd offer it. I'm used to running lots on free runners. If you want it but want to keep costs down there could be a nightly group or somesuch.

altendky avatar Feb 16 '24 20:02 altendky

Yeah we're using the larger runners to keep CI fast. I agree free runners on a slower cadence would be nice. Maybe we can only use an extended slower set on pull requests with a certain label and main.

zanieb avatar Feb 16 '24 20:02 zanieb

@altendky I'm willing to accept this, I think. We can add a guard like

if: github.ref == 'refs/heads/main' || contains(github.event.pull_request.labels.*.name, 'extended-platforms')

I'm happy to do that separately if you get it working.

zanieb avatar Feb 17 '24 05:02 zanieb

Sounds good, I'll try to get it ready for you. Rocky or Fedora might actually be more interesting, possibly, but I don't know how people tend to deploy what where. I just happened to pick amazonlinux from the failures I had seen.

altendky avatar Feb 17 '24 22:02 altendky

I figure we can have extended coverage for more platforms too in the future, e.g. alpine seems important.

zanieb avatar Feb 18 '24 07:02 zanieb

I ended up doing this.

zanieb avatar Mar 13 '24 15:03 zanieb

Thanks for following through, and my apologies for leaving it hanging. I appreciate how prompt you all have been around my queries here.

altendky avatar Mar 13 '24 21:03 altendky