ruff icon indicating copy to clipboard operation
ruff copied to clipboard

nan-comparison code mismatch with Pylint

Open BlindChickens opened this issue 10 months ago • 3 comments

In the (W)arning category of Pylint nan-comparison has code W0177. Here

In Ruff it is coded to W0117.

Is it a mistake?

Thanks in advance

BlindChickens avatar Apr 05 '24 16:04 BlindChickens

Ahh thank you! We'll correct it. Looks like an oversight.

charliermarsh avatar Apr 07 '24 03:04 charliermarsh

@charliermarsh Hi! Can I fix it?

WindowGenerator avatar Apr 07 '24 11:04 WindowGenerator

Feel free, thanks! You'll need to update the code in codes.rs, and then also add a redirect from the old to new code in rule_redirects.rs.

charliermarsh avatar Apr 07 '24 16:04 charliermarsh

I'm gonna go ahead and fix this real quick.

charliermarsh avatar Apr 12 '24 02:04 charliermarsh

@charliermarsh Sorry to necropost like this. But I forgot to ask that this issue be updated to reflect this fix. here

BlindChickens avatar Apr 22 '24 20:04 BlindChickens