pestle icon indicating copy to clipboard operation
pestle copied to clipboard

Test Cases to Ensure full-module Generation Still Works After Refactorig.

Open astorm opened this issue 6 years ago • 2 comments

Hey @VincentMarmiesse -- apologies for not catching this before I merged one of your PRs, but it looks like changing the database id column name had some unintended consequences. Specifically, if I used the magento2:generate:full-module command to generate a full module named Pulsestorm_Helloworld with a model named Thing, the following files still reference an old style pulsestorm_helloworld_id column name

app/code/Pulsestorm/Helloworld/view/adminhtml/ui_component/pulsestorm_helloworld_things.xml
app/code/Pulsestorm/Helloworld/Ui/Component/Listing/Column/Pulsestormhelloworldthings/PageActions.php

Do you think you can handle fixing this, or do you need some guidance?

astorm avatar May 05 '18 22:05 astorm

@VincentMarmiesse ignore the above, I found the problem. I'm going to leave this issue open as "develop a test case that ensures these sort of things don't happen in the future" issue.

astorm avatar May 06 '18 17:05 astorm

Hi,

Alright, thanks!

VincentMarmiesse avatar May 07 '18 11:05 VincentMarmiesse