pestle icon indicating copy to clipboard operation
pestle copied to clipboard

Generated code is not PSR-2 compliant.

Open Vinai opened this issue 7 years ago • 2 comments

It would be nice if the generated code where PSR-2 compliant.

Vinai avatar Apr 26 '17 04:04 Vinai

Don't see any problems with this. @Vinai -- do you have a preferred linting method for PSR-2?

astorm avatar Apr 26 '17 16:04 astorm

I use vendor/bin/phpcs --standard=psr2 <path-to-module>

The Magento coding standard extends psr2 somewhat, to use it the command is
vendor/bin/phpcs --standard=dev/tests/static/framework/Magento <path-to-module>

Can't help but mention for the record that I personally don't think the Magento coding standard is very good, for example enforcing PHPDoc comments only adds noise to the code.

Vinai avatar May 04 '17 06:05 Vinai