go-astisub icon indicating copy to clipboard operation
go-astisub copied to clipboard

Published 20 hours ago • verified publisher icon asticode

Support SRT styling and bold/underline in VTT

Open kloon15 opened this issue 1 year ago • 4 comments

Hows this code looking like? Feedback appreciated.

kloon15 avatar Oct 19 '23 12:10 kloon15

Could you remove the SSA-related commits from this PR?

I don't want to mix different things in the same PR.

Thanks

asticode avatar Oct 29 '23 09:10 asticode

Could you remove the SSA-related commits from this PR?

I don't want to mix different things in the same PR.

Thanks

I done nothing to SSA, its for supporting SRT position tags which use ASS tags so figured its easier to call em that. TBH im not sure what tags most players support, but position is pretty popular.

kloon15 avatar Oct 29 '23 17:10 kloon15

I done nothing to SSA, its for supporting SRT position tags which use ASS tags so figured its easier to call em that. TBH im not sure what tags most players support, but position is pretty popular.

OK, then could you remove the 2 commits handling ASS tags from this PR? I'd rather have this change in a separate PR.

Thanks!

asticode avatar Oct 30 '23 08:10 asticode

Sure will do that.

kloon15 avatar Oct 31 '23 18:10 kloon15