go-astilectron
go-astilectron copied to clipboard
asticode
it don't need to unzip electron again and again
func (p *defaultProvisioner) Provision(ctx context.Context, appName, os, arch, versionAstilectron, versionElectron string, paths Paths) (err error) { // Retrieve provision status var s ProvisionStatus if s, err = p.ProvisionStatus(paths); err != nil { err = fmt.Errorf("retrieving provisioning status failed: %w", err) return } defer p.updateProvisionStatus(paths, &s)
// Provision astilectron
if err = p.provisionAstilectron(ctx, paths, s, versionAstilectron); err != nil {
err = fmt.Errorf("provisioning astilectron failed: %w", err)
return
}
s.Astilectron = &ProvisionStatusPackage{Version: versionAstilectron}
if (!FileExist(paths.appExecutable)){//not to unzip again electron
//not to unzip again electron
// Provision electron
if err = p.provisionElectron(ctx, paths, s, appName, os, arch, versionElectron); err != nil {
err = fmt.Errorf("provisioning electron failed: %w", err)
return
}
}
s.Electron[provisionStatusElectronKey(os, arch)] = &ProvisionStatusPackage{Version: versionElectron}
return
}
after i change like this, , init faster , unzip electron takes a lot of time ,we don t need to do it everytime .very dont check it?
What command do you run to execute your go code ?
go run *.go?
after i use astilectron-bundler to build the Astilectron demo.exe ,and use double click to run it .
how i found it because my antivirus show that it access d3dcompiler_47.dll everytime,that is system dll ,so it warn.
and after i check it and dont Provision electron secondtime ,the problem solve . my antivirus dont show again. that means Provision electron maybe has son bug ,unzip everytime. i suggest that you can use a option arg to set the electron path.that we can use self electron path. don't unzip and write it. .
It downloads Electron every time I go run main.go.
go.mod:
go 1.13
require (
github.com/asticode/go-astikit v0.6.0
github.com/asticode/go-astilectron v0.16.0
github.com/asticode/go-astilectron-bootstrap v0.4.1
)
go1.13.4 darwin/amd64.
Is that expected?
It downloads Electron every time I
go run main.go.go.mod:
go 1.13 require ( github.com/asticode/go-astikit v0.6.0 github.com/asticode/go-astilectron v0.16.0 github.com/asticode/go-astilectron-bootstrap v0.4.1 )go1.13.4 darwin/amd64.
Is that expected?
i haven t found it ,just download once in the temp dir .but unzip every time when release
@alltom if you don't specify a BaseDirectoryPath, astilectron will default to the current directory. When you run go run, it generates a different temp dir everytime.
astilectron checks whether Electron is already set up in the BaseDirectoryPath before downloading it, but as your dir path changes everytime, it downloads Electron everytime.
The best solution for this is replacing go run main.go by something like go build -o binary main.go && ./binary.
Please, make optional dialog with message "need internet connection for downloading some data. Continue? yes.no" ps Cool project! Best golang gui!
