go-astilectron-bundler icon indicating copy to clipboard operation
go-astilectron-bundler copied to clipboard

Replaced the default to be the inputpath rather than the CWD '.'

Open radding opened this issue 4 years ago • 3 comments

I need this because I am using go modules outside of the GOPATH and my structure is a little different like so:

/root
  \ cmd
    \ cmd1
      \ main.go
  \ internal
    \gui
      \ ...
bundler.json

Being able to tell the bundler to build ./cmd/cmd1 is useful. THe current implementation doesn't take into account input_path

radding avatar Oct 31 '20 14:10 radding

This makes sense. Could you add a comment above if c.InputPath != "" { explaining why you need it ? That will be useful in the future

asticode avatar Oct 31 '20 17:10 asticode

@asticode Done!

radding avatar Nov 01 '20 13:11 radding

I had forgotten to push last changes to master and your go.sum now conflicts with master's. Could you fetch last changes and not update go.sum ?

asticode avatar Nov 02 '20 11:11 asticode