go-astilectron-bundler icon indicating copy to clipboard operation
go-astilectron-bundler copied to clipboard

How to notarize built .app for macOS?

Open hellgirl opened this issue 6 years ago • 6 comments
trafficstars

According to macOS policy you need to notarize your app, there is a guide here https://medium.com/@TwitterArchiveEraser/notarize-electron-apps-7a5f988406db for electron-builder but is there a way to do it with bundler?

hellgirl avatar Nov 11 '19 16:11 hellgirl

Unfortunately, this has not been implemented in the bundler.

I'm welcoming PRs though.

asticode avatar Nov 19 '19 10:11 asticode

I also need this.

Any changes in this area ?

Anyone know if we also need code to sign windows also ?

Is it a golang tool that wraps the OS signing tools that you want ?

winwisely99 avatar Feb 18 '20 18:02 winwisely99

@winwisely99 it still hasn't been implemented and I'm still welcoming PRs if you feel like contributing.

I think windows also needs signing specially if you're using notifications.

The best would be to integrate the signing steps in the bundler project but as I don't know how signing is done for each OS, maybe it's also a good idea to do it in another project. Also, chances are the electron toolchain already provides a way to sign an astilecron app properly : that would be the first thing I would check.

asticode avatar Feb 19 '20 08:02 asticode

On Mac we get a .app output from the Bundler Signing that is straight forward.

On windows I have no idea as I don't have Windows but I presume the output from your bundler is just a standard .exe ?

Does the .App and .Exe require Electron to be somewhere on the computer to run I wonder ?

If that's the case then it's pretty easy to write golang code that calls OS signing tools.

winwisely99 avatar Feb 19 '20 20:02 winwisely99

The bundler does output an .exe file for Windows.

astilectron apps need electron to be available on the computer but, thanks to the provisioner, they take care of the provisioning themselves.

Again, I'm welcoming PRs :)

asticode avatar Feb 20 '20 10:02 asticode

Ok will see what I can whip up.

winwisely99 avatar Feb 20 '20 23:02 winwisely99