asteroid icon indicating copy to clipboard operation
asteroid copied to clipboard

(Wavesplit) Comments on the implementation

Open lienz opened this issue 4 years ago • 2 comments

https://github.com/mpariente/asteroid/blob/aa3485bc57ef1f21d37cff43fce69cc3c9c94b1c/egs/wham/WaveSplit/wavesplit.py#L143

Wavesplit uses standard convolutions, not separable (separable worked worse).

https://github.com/mpariente/asteroid/blob/aa3485bc57ef1f21d37cff43fce69cc3c9c94b1c/egs/wham/WaveSplit/wavesplit.py#L166

Before the residual stacks there is a single convolution layer with kernel size 4, 512 filters, no dilation, no stride.

lienz avatar Apr 10 '20 17:04 lienz

https://github.com/mpariente/asteroid/blob/aa3485bc57ef1f21d37cff43fce69cc3c9c94b1c/egs/wham/WaveSplit/losses.py#L38 Initializing with one-hot works better.

lienz avatar Apr 10 '20 17:04 lienz

Thanks a lot for the comments @lienz ! We're going to work on it Just linking the PR #70 for visibility.

mpariente avatar Apr 10 '20 17:04 mpariente