testsuite icon indicating copy to clipboard operation
testsuite copied to clipboard

Replaced SIPp -mp with -min_rtp_port

Open maurice2k opened this issue 1 year ago • 1 comments

SIPp parameter -mp has been replaced with -min_rtp_port in SIPp v3.7.0 (released April 2023).

maurice2k avatar Dec 12 '23 15:12 maurice2k

A little sipp history... In 3.5.2, all 3 options (-mp, -min_rtp_port, -max_rtp_port) were available. In 3.6.0, they dropped -min_rtp_port and -max_rtp_port "This removes a chunk of unnecessary rtpstream code". In 3.7.0, the same person who dropped the options, put them back again but removed the -mp option. After 3.7.2 was released, someone else put the -mp option back in but without help text so it doesn't show up when you do a sipp --help. Today, I submitted a PR to add the help text back in which was just merged. This should be available when they release v3.7.3.

So now to answer @jcolp's question... Fedora 40 actually ships sipp-3.7.2 but as far as I can tell, no other distro does and altrough I do use Fedora 40, I build and use the same sipp version that the testsuite contrib/scripts/install_prereq script istalls...v3.6.1. That's the version anyone who runs the testsuite should use if they want repeatable results.

So @maurice2k you'd need to do a few things if you want to make this compatible with various versions but I'm not sure it's worth the trouble. If we do upgrade the sipp version the testsuite uses, we'd wait for v3.7.3 to get the -mp option back.

  • [ ] Leave the yaml files all specifying -mp
  • [ ] Check the version to see which option -mp or -min_rtp_port is supported by that version and set the default to it.
  • [ ] Check the arguments passed by the iterator and replace occurrences of those options with the ones valid for the sipp version.

gtjoseph avatar May 16 '24 20:05 gtjoseph