testsuite icon indicating copy to clipboard operation
testsuite copied to clipboard

Published 20 hours ago • verified publisher icon asterisk

pjsip: Add tests for Advanced Codec Negotiation (ACN)

Open maximilianfridrich opened this issue 2 years ago • 3 comments

maximilianfridrich avatar Aug 30 '23 09:08 maximilianfridrich

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment stating "No cherry-picks required" so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add "No cherry-picks required".

asterisk-org-access-app[bot] avatar Aug 30 '23 09:08 asterisk-org-access-app[bot]

cherry-pick-to: 21 cherry-pick-to: 20 cherry-pick-to: 18

maximilianfridrich avatar Aug 30 '23 09:08 maximilianfridrich

This PR must use the corresponding asterisk PR which implements the codec negotiation:

  • https://github.com/asterisk/asterisk/pull/285

In this PR, 10 existing tests were adopted to reflect the new behavior. For those tests, pjsip.conf had to be adopted to use the new ACN settings. The default settings prefer the pending stream while these tests expect the configured settings to be preferred.

maximilianfridrich avatar Aug 30 '23 09:08 maximilianfridrich