hammer

hammer copied to clipboard

add newlines back to logs, add unit tests

2

fixes #36

langston-barrett

When running hammer build in the mantl-packaging vagrant environment, Hammer panics. For some reason info is nil. I did not look much into the cause.

Dacode45

langston-barrett

They all could have a consistent interface: ``` type Consumer interface { New() int handle() Error() error } ``` The error handling also needs to be improved.

langston-barrett

Hammer stdout logs do not always match file logs

1

When a build script fails, [Hammer logs that failure to its own stdout/stderr](https://github.com/asteris-llc/hammer/blob/6337ab5e9e72b8d4e8aae792b97109a341f2bab4/hammer/package.go#L339-L346). However the "stdout" and "stderr" fields of that log line can be empty while the log files...

langston-barrett

Currently the tests on this package are scarse! The CI build runs `go test`, but there aren't too many test functions in the first place.

langston-barrett

Hammer should eventually also target debs, its description format is powerful enough to act as a meta packaging format.

langston-barrett

For instance, mesos-agent-dynamic conflicts with mesos-agent. FPM has an option for this: ``` --conflicts CONFLICTS Other packages/versions this package conflicts with. This flag can specified multiple times. ```

langston-barrett

Check here for an example of duplication that could be avoided: https://github.com/asteris-llc/mantl-packaging/tree/master/distributive

langston-barrett

I'd love it if you could pass additional command line options through hammer to `FPM`. Specifically, `--force` would be good for my use case. I'd be happy to put in...

langston-barrett