Andrea Stagi

Results 184 comments of Andrea Stagi

@zetareticoli lascio a te capire se la soluzione รจ corretta! @rcoopcsc per favore puoi aprire una PR risolutiva?

> ### Esiste giร  una discussione sul tema che ti interessa, o su un tema simile? > * [x] Ho verificato e non esiste > > ### Versione della libreria...

> Thanks for this PR @astagi. We haven't looked at it yet but could you please remove the modifications in `dist/js`? It's going to be generated/built when we'll make the...

> I don't think we need another JS dist file. For package users, using src/index.esm.js should be enough. Have you tried it with specify bootstrap/js/src/index.esm.js? > > When the ESM...

@XhmikosR another thing that concerns me: using src/index.esm.js directly as a module would skip all the Rollup plugins chain such as Babel.. any idea on this?

@XhmikosR @julien-deramond I made some tests ([here](https://github.com/astagi/bs-treeshaking-issue/blob/main/fixed/trymodules.html) with my version supporting tree shaking and [here](https://github.com/astagi/bs-treeshaking-issue/blob/main/tree-shake-issue/trymodules.html) with the current Bootstrap version)! I will restore it alongside index.esm.js file that should correctly...

@XhmikosR @julien-deramond I've just force updated this branch, I made some tests and as @XhmikosR suggested, using only `"js/index.esm.js"` as module everything works as expected ([Luxon library uses this approach...

> Unfortunately, it is still a breaking change because the now referenced file is not passed through babel. > > That's why I only decided to include the js/index.esm.js for...

@XhmikosR @julien-deramond I can confirm that I don't have any breaking with my modification. I tried using the module in a html page ```html import { Alert, Tooltip } from...

> The change in package.json is the breaking change. Before the file was passed through Babel, now it isn't. @XhmikosR Yes I know. With my modification index.esm.js is not passed...