Jacob Wujciak-Jens

Will investigate

This type of error usually happens when the runner pod gets oom or cpu killed, did we increase the feature set that's build or something like that, that might increase...

Ah yeah that could do it, I'll see what I can do.

The runner resources where increased, should take effect soon!

It's not blank when the make file is used but that's another area I want to refactor ^^

Just for completeness sake: Yes committers can push to PRs from third parties as long as they have set the 'Maintainers are allowed to edit this pull request.' option (which...

@luhenry Ah I thought it would be just a few test in wave/. Could you then add a label to gpu enabled tests and run only those? See https://cmake.org/cmake/help/latest/command/set_tests_properties.html with...

@majetideepak @kgpai This actually broke the linux workflow: https://github.com/facebookincubator/velox/actions/runs/9761202266/workflow#L116 The issue is that an unquoted `[` on the start line opens an array. I'll open a PR to fix this...

@majetideepak no we don't, the flag is only added just before the velox build. Though it can be of course picked up from `CXX_FLAGS` if velox is a sub-build

@czentgr the job was triggerd but failed during parsing which means it doesn't show up in the check list (not a great choice on gh's part...) https://github.com/facebookincubator/velox/actions/runs/10411698998/workflow#L53 you'll have to...